+1-888-365-2779
Try Now
More in this section

Forums / General Discussions / 4.4 rendering extra br tags under content blocks

4.4 rendering extra br tags under content blocks

40 posts, 0 answered
  1. Stephen
    Stephen avatar
    14 posts
    Registered:
    12 Jan 2011
    21 Dec 2011
    Link to this post
    Hi guys,

    I've notices that after upgrading to 4.4, all my content blocks now have a br tag appended when rendered.

    It's breaking our layouts.

    Not sure how to solve this one.

    Stephen
  2. Mathias
    Mathias avatar
    10 posts
    Registered:
    19 Aug 2010
    21 Dec 2011
    Link to this post
    Hello Everybody,
    We see also a br tag at the end of each content block. Layout is completely messed up.
    Any help appreciated.
    Mathias


     
  3. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    21 Dec 2011
    Link to this post
    Same here. Shure would appreciate a quick Hotfix on this.
    Markus
  4. UI Crew
    UI Crew avatar
    99 posts
    Registered:
    24 Sep 2012
    21 Dec 2011
    Link to this post
    Hi,

    Count us in. We have a website being launched tomorrow morning which has just been stuff by the extra br inserted by the Content Block.

    We have reported this to Telerik as a bug using our partner support.

    If we get any news of a fix I will update this thread.

    Seth
  5. Sean
    Sean avatar
    271 posts
    Registered:
    31 May 2006
  6. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    22 Dec 2011
    Link to this post
    @Sean
    Thanks a lot for looking into it
    @Telerik
    Any chance this is a bug, you will fix it and have a new .dll to be downloaded. I don't really want to start using templates to fix stuff.

    Markus
  7. Mathias
    Mathias avatar
    10 posts
    Registered:
    19 Aug 2010
    22 Dec 2011
    Link to this post

    @Telerik:
    I'd also like to know if there are plans to fix this behaviour with an update ?

    Mathias

  8. Victor Velev
    Victor Velev avatar
    1345 posts
    Registered:
    06 Jul 2015
    22 Dec 2011
    Link to this post
    Hi,

    The issue will be fixed in our upcoming release.

    For now the only solution is to map a template for the content block.

    Regards,
    Victor Velev
    the Telerik team
    Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items
  9. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    22 Dec 2011
    Link to this post
    @Victor

    Upcomming release as in 4.4 SP1 Janaury or 5.0?

    So simply everbody using 4.4 is forced to this workaround?

    Markus
  10. Matt
    Matt avatar
    24 posts
    Registered:
    17 Sep 2009
    22 Dec 2011
    Link to this post
    My temp fix was to add this style to the page: but it could mess up other styles you may have

    .sfContentBlock{
    margin-bottom: -1em;
    }
  11. Eric
    Eric avatar
    60 posts
    Registered:
    24 Feb 2011
    22 Dec 2011
    Link to this post
    An immediate hot-fix/upgrade for this problem would be most helpful! Our site needs to go live in a week and this is making it look bad. Please release it!
  12. Fabien
    Fabien avatar
    1 posts
    Registered:
    22 Nov 2011
    23 Dec 2011
    Link to this post
    @ Sean : Thanks for your solution but apparently it doesn't work for a content block inside a page template...
  13. Daniel Plomp
    Daniel Plomp avatar
    952 posts
    Registered:
    18 Feb 2004
    23 Dec 2011
    Link to this post
    Hey guys,

    I've also added this ViewMap to the settings:

    HostType:
    Telerik.Sitefinity.Modules.GenericContent.Web.UI.ContentBlockBase

    LayoutTemplatePath:
    .. to your template...

    This will then fix the <br /> issue on templates as well.

    Regars,
    Daniel

  14. Jen Peleva
    Jen Peleva avatar
    568 posts
    Registered:
    10 Nov 2016
    27 Dec 2011
    Link to this post
    Hi guys,

    Our next release is scheduled for February. @Sean's workaround is the best thing that can be done at this point, and as @Daniel properly pointed out, you need to map the template through ViewMap to change the behavior of all content blocks in your projects. Another workaround would be to remove the br tag with a simple jquery declaration:
    $("div.sfContentBlock > br").remove();

    Greetings,
    Jen Peleva
    the Telerik team
    Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items
  15. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    28 Dec 2011
    Link to this post
    February? Seriously??
  16. Webteam
    Webteam avatar
    28 posts
    Registered:
    30 Nov 2009
    30 Dec 2011
    Link to this post
    same issue here, 4.4 completely messed up the styles in our site with the extra <br>.  I would like to see it addressed in a hotfix as well.
  17. Ann
    Ann avatar
    7 posts
    Registered:
    21 Dec 2010
    02 Jan 2012
    Link to this post
    Doesn't your suggested fix remove all BR tags from the content?  Seems it would be more correct to just remove the last matching BR tag:

    $("div.sfContentBlock > br").filter(":last").remove();

    Matt

  18. Jen Peleva
    Jen Peleva avatar
    568 posts
    Registered:
    10 Nov 2016
    03 Jan 2012
    Link to this post
    Hi,

    Thanks for the correction, Mark. You are right that removing the last </br> tag is a better approach, since my code would remove all </br> tags in the content block.

    All the best,
    Jen Peleva
    the Telerik team
    Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items
  19. antoniodlp
    antoniodlp avatar
    13 posts
    Registered:
    28 Mar 2007
    18 Jan 2012
    Link to this post
    You can also try this CSS solution:

    .sfContentBlock > br:last-child { display: none; }

    Should work for most.
  20. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    06 Mar 2012
    Link to this post
    FWIW - just upgraded to V5.0 and seems to still be the same.
  21. Nidhi
    Nidhi avatar
    40 posts
    Registered:
    20 Jul 2010
    06 Mar 2012
    Link to this post
    For anyone who may want to know,
    I just upgraded my website to Sitefinity 5 and this issue has still not been fixed.
    Am using raindogmx's solution meanwhile
    .sfContentBlock > br:last-child { display: none; }
  22. SVA Webmaster
    SVA Webmaster avatar
    85 posts
    Registered:
    18 Jul 2007
    06 Mar 2012
    Link to this post
    To quote Victor on Dec 22: 

    "The issue will be fixed in our upcoming release. "

    I can't even get a successful upgrade rolling from 4.4 to 5.0, nor a fresh install of 5.0 on a Win2008R2 server and it looks like I have nothing to look forward to even if I could. The only reason we were even looking forward to 5.0 is to get fixes to all of the incredibly obvious bugs everyone has been reporting about for months and we don't get those fixed, but we get new bugs and new features. A lot of good new features does anyone if it doesn't work. I'm about ready to dump Sitefinity and I'm tired of spending hours and hours writing work-arounds and jerry-rigging my sites to get around these ridiculous issues.

    I'm not typically a complainer, but my patience has been stretched incredibly thin. In 15 years of my development career, I've never encountered such a frustrating piece of software. 
  23. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    06 Mar 2012
    Link to this post
    @Nidhi

    I don't believe that the css solution will work for IE8 and earlier.

    FWIW: I used the jQuery hack and inserted it onto my base masterpage.

    <script type="text/javascript">
        //-- Hack for SF 4.4-5.0 ContentBlock Bug --//
        $(document).ready(function () { $("div.sfContentBlock > br").filter(":last").remove(); });
    </script>
  24. Thomas
    Thomas avatar
    223 posts
    Registered:
    19 Jan 2011
    07 Mar 2012
    Link to this post
    @Nidhi:

    "For anyone who may want to know,
    I just upgraded my website to Sitefinity 5 and this issue has still not been fixed."

    Seriously? Do you mean you upgraded your site to SF 4.4, which triggered the br bug, then upgraded to 5.0 and expected your content to be fixed? (I wouldn't.) Or do you actually mean that if I upgrade my SF 4.3 to 5.0, my content will get corrupt even though I skipped 4.4?
  25. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    07 Mar 2012
    Link to this post
    @thomas
    Interesting question. Well you should be able to upgrade 4.3 to 5.0 as Telerik claims you can upgrade two versions back. I am interested if 5.0 introduces the same bug as 4.4

    @Telerik
    If the bug really is not fixed then I must say. Most of us expect known bug to fixed between major releases.



    The question remindes me of this question.
    If a cat falls of a building it will always land on its feet
    If you butter a peace of bread and drop it, it will always land on the side with the butter on it.
    Question
    What happens if you would put butter on the back of a cat :-)

  26. Thomas
    Thomas avatar
    223 posts
    Registered:
    19 Jan 2011
    07 Mar 2012
    Link to this post
    "If the bug really is not fixed then I must say. Most of us expect known bug to fixed between major releases."

    They can't fix all the bugs, obviously, but content corruption bugs should be given the highest priority.
  27. Nick
    Nick avatar
    113 posts
    Registered:
    21 Oct 2008
    07 Mar 2012
    Link to this post
    This is really frustrating. I do wonder if they should put a little (or a lot) more emphasis on bug fixes rather than releasing new features.

    Where is the PITS for this bug?
  28. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    07 Mar 2012
    Link to this post
    @Thomas
    I don't believe its actually a content corruption bug - but rather, it's a rendering bug. The extra br is not actually inserted into the stored content (first thing I checked) but simply added during the rendering, by the control's code/template. Thus fixing the bug should "remove" the extra br seen on 4.4 sites.

    @Markus
    Yep, it's the same bug. I had skipped 4.4 as there was nothing there I needed and I preferred not to implement a hack to deal with something that was going to be fixed in the next release. Unfortunately, as we now know, it wasn't fixed, and so I've implemented a suitable hack, in a place where I know I can easily locate and remove it, when no longer required.
  29. SVA Webmaster
    SVA Webmaster avatar
    85 posts
    Registered:
    18 Jul 2007
    07 Mar 2012
    Link to this post
    I posted a highly discussed thread a month or more ago about their release and bug resolution practices. Essentially, Sitefinity said they are driven by aggressive new technology releases and that's what their customers want.

    I beg to differ in opinion based on the fact that aggressive new technology does none of us good if it's bug-laden. Furthermore, they don't believe in iterative "bug releases". There is always new functionality in a release and bugs come second. Many of us are still waiting on fixes for bugs introduced multiple versions ago. Right now features in my sites are crippled or jerry-rigged as a result of OBVIOUS, silly bugs (such as the injection of the unwanted <br/>) we're still waiting on fixes for. Because I don't get a patches-only service pack for my installs, I have to wait for releases like 5.0 that I can't even upgrade successfully just to get SOME of my bug fixes in place because its full of new technology that is breaking my existing sites. As a developer and IT professional, this is a maddening practice.

    I'm supposed to be having a meeting with my superiors tomorrow to discuss how the testing of 5.0 and 4.4 to 5.0 upgrade tests went. Given how badly it's gone, I am prepared to go in to the meeting tomorrow and recommend we drop Sitefinity. The reason we purchased it was because it was supposed to help relieve me and my team of the hours required to accomplish our web-based business development goals. I've only been on this platform for a year (4.0 to now) and being on Sitefinity has actually taken MORE of my team's development hours than had we just stuck to our custom asp.net website and homemade SQL backend. The sad thing is, we're not even doing anything fancy with this software. We just want the out-of-the box stuff to work like it should.


  30. Thomas
    Thomas avatar
    223 posts
    Registered:
    19 Jan 2011
    08 Mar 2012
    Link to this post
    @MB: thanks for the info. I assumed it was a content corruption bug, just like 4.2 SP1 corrupted image tags within content blocks.

    That said, I don't understand why the fix didn't make it in 5.0, as Sitefinity admins said it would. But history repeats itself, as the same thing happened before on multiple occasions. Do you know the saying "Underpromise and overdeliver"? It's the other way around, here.
40 posts, 0 answered
1 2