1-888-365-2779
+1-888-365-2779
Try Now
More in this section

Forums / General Discussions / After 4.2SP1 upgrade img tags are broken

After 4.2SP1 upgrade img tags are broken

19 posts, 0 answered
  1. Mark
    Mark avatar
    147 posts
    Registered:
    01 Jun 2010
    30 Sep 2011
    Link to this post
    Prior to upgrading from 4.2 to 4.2SP1 my img tags were well formed. After upgrading I have hundreds of broken links. The alt tag is breaking the tag directly after it (width, style or src) Here are some examples:

    <img alt="width="150"" src="/images/session-7-video-images/good-bad-ugly.png" sfref="[images]01d1c5d2-8e24-4398-900a-99c1f123620b" />
     
    <img alt="width="150"" src="/images/session-7-video-images/how-do-i-get-a-website.png" sfref="[images]964107e3-8e94-425e-8052-0886996018d6" />
     
    <img alt="style="width:" src="/images/session-7-video-images/www-tips.png" sfref="[images]4e5045f1-15a2-45d6-bf13-e78e442ccd42" />

    Is there a fix for this yet?
  2. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    02 Oct 2011
    Link to this post
    Similar experience... on tags with alt=""  they were broken and the src spec inserted... but with incorrect quote count.

    Fortunately it was only a development site, and I could correct them all by hand.
  3. Steve
    Steve avatar
    3037 posts
    Registered:
    03 Dec 2008
    02 Oct 2011
    Link to this post
    I've had this happen as well
  4. Mark
    Mark avatar
    147 posts
    Registered:
    01 Jun 2010
    03 Oct 2011
    Link to this post
    Has anyone from Telerik been able to replicate this issue? It's happened with the three sites I've attempted to update. I did have SQL backups and could roll back, but I'd like to upgrade my other sites.
  5. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    04 Oct 2011
    Link to this post
    I would also be interested to hear from Telerik about this. I was about to update 3 sites but holding back because of this.

    @mark, steve, mb
    Could you tell telerik from what version you were updating. Maybe that helps them reproduce the issue

    Markus
  6. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    04 Oct 2011
    Link to this post
    For me, it was from 4.2
  7. Knut
    Knut avatar
    36 posts
    Registered:
    12 Apr 2009
    04 Oct 2011
    Link to this post
    Its also happen for all our sites in projectdevelopment.. some large accounts as well.... There must be a hotfix for this....
  8. Magnus
    Magnus avatar
    3 posts
    Registered:
    29 Sep 2011
    04 Oct 2011
    Link to this post
    Same problem.

    Upgraded from 4.2.1650 to 4.2.1733 (SP1) and all the img tags are broken by the alt tag.

    Any fix?
  9. Victor Velev
    Victor Velev avatar
    1345 posts
    Registered:
    06 Jul 2015
    04 Oct 2011
    Link to this post
    Hello Magnus,

    We know of the issue related to the image tags being broken. Its is relevant to images with alt attributes with no value inserted in a non-shared content in a ContentBlock control. In this case the image HTML is like this one: However we have prepared a patch that should fix the issue. You can find in the attached archive Telerik.Sitefinity.Utlities.dll. It needs to replace the same file in your ~/bin folder.

    Best wishes,
    Victor Velev
    the Telerik team
    Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items
  10. Mark
    Mark avatar
    147 posts
    Registered:
    01 Jun 2010
    04 Oct 2011
    Link to this post
    Thank you for the fix. Is this new assembly included in the latest 4.1 SP1 download?
  11. Victor Velev
    Victor Velev avatar
    1345 posts
    Registered:
    06 Jul 2015
    04 Oct 2011
    Link to this post
    Hello Mark,

    It will be included in our next release ( the internal build that is coming at the end of the week ) and the others after it.

    Regards,
    Victor Velev
    the Telerik team
    Do you want to have your say in the Sitefinity development roadmap? Do you want to know when a feature you requested is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items
  12. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    04 Oct 2011
    Link to this post
    @Victor

    So the recomended update path is

    - take a working 1650
    - break it by updating it to 1733
    - fix it by using the patch

    Since the internal builds are not to used in productions.

    Is this really the way to go or is it better to wait for 4.3?

    Markus
  13. Steve
    Steve avatar
    3037 posts
    Registered:
    03 Dec 2008
    04 Oct 2011
    Link to this post
    @Markus
    Lol, are you being rhetorical? :)

    It's not that inconvenient really...drop in a new DLL, doesn't require a recompile. You don't update the same project multiple times, so it's just a small step.  I'd just do your 3 steps and be done with it :)

    Doesn't make any logical sense to wait for 4.3 if your site is live with broken images

    Steve
  14. Markus
    Markus avatar
    2763 posts
    Registered:
    25 Nov 2005
    04 Oct 2011
    Link to this post
    @Telerik

    Sorry and thanks for the quick fix.

    @Steve
    50:50.

    Yes, rhetorical because I usually wonder about the solutions Telerik provides. Like the Hotfix that was not included in the 1650 once they had it.

    No, because it seemed that 4.2 SP2 did break something and am not sure if tha patch is going to fix it really.
    Will wait a couple of post to get more feeback like your: patch worked like a charm.

    It's said but I have begun to wait 1-2 weeks before doing any updates. Never know these days.

    Markus
  15. Mark
    Mark avatar
    147 posts
    Registered:
    01 Jun 2010
    04 Oct 2011
    Link to this post
    @Markus, I just applied the fix to a fresh upgrade and I do not have the img problem like I had in the previous upgrades. My steps: perform the sitefinity upgrade, replace the dll, build.
  16. MB
    MB avatar
    302 posts
    Registered:
    09 Jan 2005
    04 Oct 2011
    Link to this post
    The patch can't UNDO damage done by SP1, can it ?? - I wouldn't think so.

    Assuming not, I would imagine that an important step in the upgrade is:

    - Perform 4.2-SP1 upgrade
    - *DO NOT RUN, BUILD OR TEST THE SITE*
    - replace the dll
  17. Brian Crosby
    Brian Crosby avatar
    29 posts
    Registered:
    02 Jan 2006
    05 Oct 2011
    Link to this post
    My understanding is that the problem has to do with how HTML is rendered, not how it is stored in the DB. The stored HTML is run through a method that checks links and images with sfref attributes and updates the href or src tag so that the path is always correct when the page is rendered. There seems to be an error with this method which is mangling the rendered HTML. Replacing the DLL fixes this method and all is mostly right again. I think it still has a few quirks in it but it is better than it was before. Also, fixing the HTML in the editor and republishing the content seems to fix it.   
  18. Tom Miller
    Tom Miller avatar
    52 posts
    Registered:
    27 Feb 2010
    05 Oct 2011
    Link to this post
    It would be nice to have this verified, as this is reasonable.
  19. Andrei
    Andrei avatar
    553 posts
    Registered:
    27 Nov 2008
    05 Oct 2011
    Link to this post
    Victor

    Thanks for the DLL, it fixed my images.
    Andrei
19 posts, 0 answered